Jean, > When evaluating the 'block limits' VPD page we need to check if the > 'lbpme' (logical block provisioning management enable) bit is set in > the READ CAPACITY (16) output. If it isn't we can safely assume that > we cannot use DISCARD on this device. That's not entirely correct. We still support devices which predate logical block provisioning getting standardized in SBC. These devices are typically driven by the zeroing method and don't have LBPME, nor the LBP VPD page to key off of. Instead they are triggered by setting the provisioning_mode via udev. I am not sure how many of these are still around, I am hoping very few. But I'd prefer to not break anything. Can you describe the specific problem your patch is aiming to address? -- Martin K. Petersen Oracle Linux Engineering