Hi Sedat, Thank you for the patch! Yet something to improve: [auto build test ERROR on scsi/for-next] [also build test ERROR on v5.0-rc4 next-20190215] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Hannes-Reinecke/fcoe-make-use-of-fip_mode-enum-complete/20190215-175222 base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next config: x86_64-randconfig-x017-201906 (attached as .config) compiler: gcc-8 (Debian 8.2.0-20) 8.2.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): drivers/scsi//fcoe/fcoe_ctlr.c: In function 'fcoe_ctlr_link_up': >> drivers/scsi//fcoe/fcoe_ctlr.c:460:4: error: implicit declaration of function 'fcoe_ctrl_set_state'; did you mean 'fcoe_ctlr_set_state'? [-Werror=implicit-function-declaration] fcoe_ctrl_set_state(fip, FIP_ST_AUTO); ^~~~~~~~~~~~~~~~~~~ fcoe_ctlr_set_state cc1: some warnings being treated as errors vim +460 drivers/scsi//fcoe/fcoe_ctlr.c 443 444 /** 445 * fcoe_ctlr_link_up() - Start FCoE controller 446 * @fip: The FCoE controller to start 447 * 448 * Called from the LLD when the network link is ready. 449 */ 450 void fcoe_ctlr_link_up(struct fcoe_ctlr *fip) 451 { 452 mutex_lock(&fip->ctlr_mutex); 453 if (fip->state == FIP_ST_NON_FIP || fip->state == FIP_ST_AUTO) { 454 mutex_unlock(&fip->ctlr_mutex); 455 fc_linkup(fip->lp); 456 } else if (fip->state == FIP_ST_LINK_WAIT) { 457 if (fip->mode == FIP_MODE_NON_FIP) 458 fcoe_ctlr_set_state(fip, FIP_ST_NON_FIP); 459 else > 460 fcoe_ctrl_set_state(fip, FIP_ST_AUTO); 461 switch (fip->mode) { 462 default: 463 LIBFCOE_FIP_DBG(fip, "invalid mode %d\n", fip->mode); 464 /* fall-through */ 465 case FIP_MODE_AUTO: 466 LIBFCOE_FIP_DBG(fip, "%s", "setting AUTO mode.\n"); 467 /* fall-through */ 468 case FIP_MODE_FABRIC: 469 case FIP_MODE_NON_FIP: 470 mutex_unlock(&fip->ctlr_mutex); 471 fc_linkup(fip->lp); 472 fcoe_ctlr_solicit(fip, NULL); 473 break; 474 case FIP_MODE_VN2VN: 475 fcoe_ctlr_vn_start(fip); 476 mutex_unlock(&fip->ctlr_mutex); 477 fc_linkup(fip->lp); 478 break; 479 } 480 } else 481 mutex_unlock(&fip->ctlr_mutex); 482 } 483 EXPORT_SYMBOL(fcoe_ctlr_link_up); 484 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip
