Re: [PATCH 0/4] scsi: fixup dma_set_mask_and_coherent() calls

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/14/19 6:31 PM, Christoph Hellwig wrote:
On Thu, Feb 14, 2019 at 09:29:05AM +0000, John Garry wrote:
On 13/02/2019 18:51, Ewan D. Milne wrote:
On Wed, 2019-02-13 at 12:42 +0100, Hannes Reinecke wrote:
The recent patchset to use dma_set_mask_and_coherent() introduced
a regression where a call to set a 64-bit DMA mask was followed
by a call to set a 32-bit DMA mask, leading to I/O errors and
data corruption.

Patchset is based on a suggestions from Ewan Milne.

Hannes Reinecke (4):
   lpfc: fix calls to dma_set_mask_and_coherent()
   hptiop: fix calls to dma_set_mask_and_coherent()
   bfa: fix calls to dma_set_mask_and_coherent()
   hisi_sas: fix calls to dma_set_mask_and_coherent()

  drivers/scsi/bfa/bfad.c               | 10 +++++++---
  drivers/scsi/hisi_sas/hisi_sas_main.c |  8 ++++++--
  drivers/scsi/hptiop.c                 | 10 +++++++---
  drivers/scsi/lpfc/lpfc_init.c         |  9 ++++++---
  4 files changed, 26 insertions(+), 11 deletions(-)

Isn't there a few more to fix up, like:
drivers/scsi/3w-9xxx.c
drivers/scsi/3w-sas.c
drivers/scsi/csiostor/csio_init.c

Yeah, there is a few more.  And the sad part is as of a few kernel
release ago we shouldn't even need the fallback 32-bit dma mask
anymore - we've cleaned up all the mess that required it.

Care to elaborate?
Can you point me to the respective commits facilitating that?

I'd gladly update the drivers...

Cheers,

Hannes



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux