Hi Martin,
Am Mittwoch, 13. Februar 2019, 04:53:07 CET schrieb Martin K. Petersen:
>
> Hi Dietmar,
>
> This didn't cause any real grief since all callers have an sdkp. But
> it's definitely a typo on my part. I applied your patch to
> 5.1/scsi-queue.
>
> Your contribution didn't quite follow the Linux kernel patch submission
> guidelines. I fixed up the warnings before committing but I encourage
> you to read:
>
> Documentation/process/submitting-patches.rst
Yes I knew that. It wasn't meant as real patch, more a hint because I saw
that this was not a real problem.
But for a possible next one ...
Thanks.
Dietmar.
>
> Thanks!
>
> > commit b2bff6ceb61a9 added the macro sd_first_printk().
> > It seems there is a copy error:
> >
> > diff --git a/drivers/scsi/sd.h b/drivers/scsi/sd.h
> > index 7f43e6839bce..cce0e96191e7 100644
> > --- a/drivers/scsi/sd.h
> > +++ b/drivers/scsi/sd.h
> > @@ -132,7 +132,7 @@ static inline struct scsi_disk *scsi_disk(struct gendisk *disk)
> >
> > #define sd_first_printk(prefix, sdsk, fmt, a...) \
> > do { \
> > - if ((sdkp)->first_scan) \
> > + if ((sdsk)->first_scan) \
> > sd_printk(prefix, sdsk, fmt, ##a); \
> > } while (0)
> >
> > Dietmar.
