On Tue, Feb 12, 2019 at 10:37:45AM -0500, Ewan D. Milne wrote: > > It looks like this would introduce a different problem. "error" is set to > -ENODEV earlier in the two functions so that the various error paths will return > that value. If it is overwritten with a successful result from the call to > dma_set_mask_and_coherent() but a later call to e.g. ioremap() fails, the > functions will incorrectly return a value indicating that they have succeeded. > > It also appears as if the patches to hptiop, hisi_sas and bfa need to be fixed up. > I don't have a test environment for these, although I might be able to modify the > test environment for bfa. Martin/James, what about the others? I don't have a test environment for them either, and I doubt many people have. If you don't feel comfortable I can send a fix for them.
