Re: [PATCH] scsi_debug: Fix a recently introduced regression

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2019-02-12 2:57 a.m., Christoph Hellwig wrote:
On Fri, Feb 08, 2019 at 01:21:27PM -0800, Bart Van Assche wrote:
A recent commit removed an element from opcode_info_arr[] but did not
modify opcode_ind_arr[] nor was SDEB_I_XDWRITEREAD removed. Remove
SDEB_I_XDWRITEREAD and bring the two arrays again in sync. This patch
avoids that the following is reported:

This looks fine to me:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

But that whole table scheme looks way to fragile to me..

Yes, as it was designed to help people add, not remove, functionality.
Also it makes the output of REPORT SUPPORTED OPERATION CODES totally
believable, unlike many real SCSI devices and target emulations.

Doug Gilbert





[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux