On 04/01/2019 16:45, Bart Van Assche wrote:
On Fri, 2019-01-04 at 11:18 -0500, Douglas Gilbert wrote:
Add a top level "scsi" directory in debugfs (usually at
/sys/kernel/debugfs/scsi) with two subdirectories: "uld" and "lld".
The idea is to place mid-level related 'knobs' in the "scsi"
directory, and for the ULDs to make subsirectories like
"scsi/uld/sd" and "scsi/uld/st" as required. LLDs could follow a
similar pattern.
Changes since v2:
- export symbols so other driver can use them [John Garry]
- make prior code conditional on CONFIG_BLK_DEBUG_FS
Changes since v1:
- tweak Makefile to keep kbuild test robot happier
A patch like this doesn't make sense on it's own. Please repost it
together with the patches that use the directories created by this patch.
Please also leave out the debugfs directories that are not used by the
patches in the series that you will post.
I have already asked my colleagues if any objection with relocating
hisi_sas lld debugfs directory to this new location (should be ok, since
not a stable ABI). If not, then we can add that to the patch.
<snip>
> +#ifdef CONFIG_DEBUG_FS
> +struct dentry *scsi_debugfs_root;
> +struct dentry *scsi_debugfs_uld;
> +struct dentry *scsi_debugfs_lld;
> +
> +EXPORT_SYMBOL(scsi_debugfs_root);
> +EXPORT_SYMBOL(scsi_debugfs_uld);
> +EXPORT_SYMBOL(scsi_debugfs_lld);
> +
> +#endif
Do uld and root dentrys need to be exported also? I was only concerned
about lld since drivers are generally modules.
Thanks,
John
Thanks,
Bart.
