Re: [PATCH 02/25] lpfc: cleanup: Remove excess check on NVME io submit code path

[Hannes Reinecke <hare@xxxxxxx>]

On 12/27/18 12:33 AM, James Smart wrote:
> lpfc_nvme_prep_io_cmd() checks for null pnode, but caller
> lpfc_nvme_fcp_io_submit() has already ensured it's non-null.
>
> remove the pnode null check
>
> Signed-off-by: Dick Kennedy <dick.kennedy@xxxxxxxxxxxx>
> Signed-off-by: James Smart <jsmart2021@xxxxxxxxx>
> ---
>   drivers/scsi/lpfc/lpfc_nvme.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_nvme.c b/drivers/scsi/lpfc/lpfc_nvme.c
> index b59bf37af881..d3e955f70894 100644
> --- a/drivers/scsi/lpfc/lpfc_nvme.c
> +++ b/drivers/scsi/lpfc/lpfc_nvme.c
> @@ -1190,7 +1190,7 @@ lpfc_nvme_prep_io_cmd(struct lpfc_vport *vport,
>   	union lpfc_wqe128 *wqe = &pwqeq->wqe;
>   	uint32_t req_len;
>   
> -	if (!pnode || !NLP_CHK_NODE_ACT(pnode))
> +	if (!NLP_CHK_NODE_ACT(pnode))
>   		return -EINVAL;
>   
>   	/*
Reviewed-by: Hannes Reinecke <hare@xxxxxxxx>

Cheers,

Hannes