On Wed, Oct 11, 2006 at 03:51:40PM +0100, Alan Cox wrote:
> Ar Llu, 2006-10-09 am 01:16 +0200, ysgrifennodd Adrian Bunk:
> > The Coverity checker spotted this dead code introduced by
> > commit a07f353701acae77e023f6270e8af353b37af7c4.
> >
> > Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx>
>
> Semi-NAK
>
> Its not dead jim, its in the wrong location
>
> > while ((pDev = pci_get_device( PCI_DPT_VENDOR_ID, PCI_ANY_ID, pDev))) {
> > if(pDev->device == PCI_DPT_DEVICE_ID ||
> > pDev->device == PCI_DPT_RAPTOR_DEVICE_ID){
> > if(adpt_install_hba(sht, pDev) ){
> > PERROR("Could not Init an I2O RAID device\n");
> > PERROR("Will not try to detect others.\n");
>
> ------------------------> pci_dev_put()
>
> is needed there instead I think.
>...
The current code is:
/* search for all Adatpec I2O RAID cards */
while ((pDev = pci_get_device( PCI_DPT_VENDOR_ID, PCI_ANY_ID, pDev))) {
if(pDev->device == PCI_DPT_DEVICE_ID ||
pDev->device == PCI_DPT_RAPTOR_DEVICE_ID){
if(adpt_install_hba(sht, pDev) ){
PERROR("Could not Init an I2O RAID device\n");
PERROR("Will not try to detect others.\n");
return hba_count-1;
}
pci_dev_get(pDev);
}
}
if (pDev)
pci_dev_put(pDev);
I don't see the point of the suggested place for the pci_dev_put()
since pci_dev_get() has never been executed in this case, or do I miss
anything?
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
