Re: [patch 34/36] Maintain module-parameter name consistency with qla2xxx/qla4xxx.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 10 Oct 2006, akpm@xxxxxxxx wrote:

> From: Andrew Vasquez <andrew.vasquez@xxxxxxxxxx>
> 
> -ENOCHANGELOG.
> 
> Don't know who wrote it.

it was a simple "perl -pi -e '" thingy...

> 
> Signed-off-by: Andrew Vasquez <andrew.vasquez@xxxxxxxxxx>
> Cc: James Bottomley <James.Bottomley@xxxxxxxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxx>


Fredrick posted the following patch to address a variable name
conflict in the recently added qla4xxx driver:

http://article.gmane.org/gmane.linux.kernel/453703

I'd suggested that the prefix be ql2x/ql4x rather than qla2_/qla4_ for
consistency (some at least):

http://article.gmane.org/gmane.linux.kernel/453769


Linus ended up adding Fredrick's patch to the linux-2.6 tree.  I then
ended up rediffing and posting the updated patch (you've now added to
mm):

http://article.gmane.org/gmane.linux.kernel/454031


Sorry for the confusion -- how's this (too verbose):

---
Maintain module-parameter name consistency with qla2xxx/qla4xxx.

The recently added the iSCSI qla4xxx driver contains a global
(non-static) variable that clashes with a pre-existing variable
present in qla2xxx.

Commit d7a297baa6edea94167163bed808c6a8933bd5aa added a 'qla2_'
and 'qla4_' prefix to the offending variable name.  Replace the
'qla2_/qla4_' prefixes with 'ql2x/ql4x' to maintain consistency
with other module-parameters.

Signed-off-by: Andrew Vasquez <andrew.vasquez@xxxxxxxxxx>
---
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux