Re: [PATCH] sd: use mempool for discard special page

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/12/18 7:35 AM, Jens Axboe wrote:
> On 12/12/18 7:21 AM, Christoph Hellwig wrote:
>> Looks good:
>>
>> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
>>
>> Note that NVMe will need the same treatment.
> 
> Indeed, I'll prep one for that too.

That one is a little worse, since we only need a full page if we
use all 256 segments. I don't want to make the fast case of
16 bytes single segment allocs get a full page, so we have to
track if we used kmalloc() or mempool_alloc() for this particular
range.

I guess I could abuse ->end_io for that, set it if we end up
punting to mempool. I'll do that.

-- 
Jens Axboe




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux