On 07/12/2018 11:07, John Garry wrote: > On 06/12/2018 16:20, Johannes Thumshirn wrote: >> On 06/12/2018 16:37, John Garry wrote: >>> which is important. Let me know if you disagree and I can change it. >> >> Sure, it's your driver. It was just because the patch is even titled >> "Relocate some code to reduce complexity", so I thought of reducing the >> complexity for readers even further (like you don't need the line wrap >> at 80 chars, and so on). >> >> Byte, >> Johannes >> > > I would rather not change if you don't mind. When we say "reduce > complexity", we are talking about moving the DMA mapping code from the > task prep function, as, when we add the DIX-related DMA mapping code, > leaving all the DMA mapping code in the task prep function would make it > a monster. Sure -- Johannes Thumshirn SUSE Labs Filesystems jthumshirn@xxxxxxx +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
