Looks good. Apologize for the delay in acknowledging the patch.
Acked-by: Sesidhar Baddela <sebaddel@xxxxxxxxx>
On 12/4/18, 8:37 PM, "Sabyasachi Gupta" <sabyasachi.linux@xxxxxxxxx> wrote:
On Fri, Nov 23, 2018 at 8:13 PM Sabyasachi Gupta
<sabyasachi.linux@xxxxxxxxx> wrote:
>
> On Wed, Nov 14, 2018 at 10:24 PM Sabyasachi Gupta
> <sabyasachi.linux@xxxxxxxxx> wrote:
> >
> > Replaced vmalloc + memset with vzalloc
> >
> > Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@xxxxxxxxx>
>
> Any comment on this patch?
Any comment on this patch?
>
> > ---
> > v2: Removed additional braces
> >
> > drivers/scsi/fnic/fnic_trace.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/scsi/fnic/fnic_trace.c b/drivers/scsi/fnic/fnic_trace.c
> > index 8271785..bf0fd2a 100644
> > --- a/drivers/scsi/fnic/fnic_trace.c
> > +++ b/drivers/scsi/fnic/fnic_trace.c
> > @@ -468,14 +468,13 @@ int fnic_trace_buf_init(void)
> > fnic_max_trace_entries = (trace_max_pages * PAGE_SIZE)/
> > FNIC_ENTRY_SIZE_BYTES;
> >
> > - fnic_trace_buf_p = (unsigned long)vmalloc((trace_max_pages * PAGE_SIZE));
> > + fnic_trace_buf_p = (unsigned long)vzalloc(trace_max_pages * PAGE_SIZE);
> > if (!fnic_trace_buf_p) {
> > printk(KERN_ERR PFX "Failed to allocate memory "
> > "for fnic_trace_buf_p\n");
> > err = -ENOMEM;
> > goto err_fnic_trace_buf_init;
> > }
> > - memset((void *)fnic_trace_buf_p, 0, (trace_max_pages * PAGE_SIZE));
> >
> > fnic_trace_entries.page_offset =
> > vmalloc(array_size(fnic_max_trace_entries,
> > --
> > 2.7.4
> >
