On 11/27/18 9:21 PM, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Addresses-Coverity-ID: 1056537 ("Missing break in switch") > Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx> > --- > drivers/scsi/BusLogic.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/scsi/BusLogic.c b/drivers/scsi/BusLogic.c > index 9cee941f97d6..717eef3ee893 100644 > --- a/drivers/scsi/BusLogic.c > +++ b/drivers/scsi/BusLogic.c > @@ -2641,6 +2641,7 @@ static int blogic_resultcode(struct blogic_adapter *adapter, > case BLOGIC_BAD_CMD_PARAM: > blogic_warn("BusLogic Driver Protocol Error 0x%02X\n", > adapter, adapter_status); > + /* fall through */ > case BLOGIC_DATA_UNDERRUN: > case BLOGIC_DATA_OVERRUN: > case BLOGIC_NOEXPECT_BUSFREE: > Looks good. Acked-by: Khalid Aziz <khalid@xxxxxxxxxxxxxx>