On 12/2/18 10:21 PM, Finn Thain wrote:
On Sun, 2 Dec 2018, Hannes Reinecke wrote:
Well, that lone 'kmap' is due to a quirk/errata in the datasheet; essentially
we have to PIO a lone byte out of the FIFO to clear it up.
And this byte is technically still part of the SCSI data, so we need to
stuff it onto the end of the actual data sg list. Which is what the kmap()
thingie does.
So it really shouldn't be affected by the clustering algorithm.
Sorry, I don't follow.
If it's dead code, can it be removed
Oh, it's not dead code. It's required as per datasheet.
If it's not, does it require DISABLE_CLUSTERING?
No, not really. It just affects the very last byte of the sglist,
so I can't really see how it should be affected by clustering.
Cheers,
Hannes
