On Fri, Oct 06 2006, Arjan van de Ven wrote: > On Thu, 2006-10-05 at 10:08 -0700, Stephen Hemminger wrote: > > This is current main linux-2.6 (git pulled yesterday). > > Running on 2 CPU Opteron > > Happened during overnight (beagle cronjob?) > > hmm lots of changes in cfq, and to be honest the > cfq_exit_single_io_context() change makes me nervous. > The comment says it's called with interrupts disabled, what the comment > does NOT say is that this function ENABLES interrupts! > (the entire cfq change has many places where interrupts now get enabled > where previously they remained as is... ) The comment is stale, it isn't called with interrupts disabled (or the spin_lock_irq() and unlock would be buggy). The lockdep trace is interesting though, added to the list of things to investigate ASAP. -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
