On Fri, Nov 23, 2018 at 06:36:11PM +0100, David Disseldorp wrote: > On write, the pi_prot_format configfs attribute invokes the device > format_prot() callback if present. Read dumps the contents of > se_dev_attrib.pi_prot_format , which is always zero. > Make the configfs attribute write-only, and drop the always zero > se_dev_attrib.pi_prot_format storage. Looks good, Reviewed-by: Christoph Hellwig <hch@xxxxxx>