On Tue, Nov 13, 2018 at 9:23 PM Johannes Thumshirn <jthumshirn@xxxxxxx> wrote: > > On 13/11/2018 16:44, John Garry wrote: > > On 13/11/2018 15:08, Sabyasachi Gupta wrote: > >> Replaced vmalloc + memset with vzalloc > >> > >> Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@xxxxxxxxx> > >> --- > >> drivers/scsi/fnic/fnic_trace.c | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> > >> diff --git a/drivers/scsi/fnic/fnic_trace.c > >> b/drivers/scsi/fnic/fnic_trace.c > >> index 8271785..129ab27 100644 > >> --- a/drivers/scsi/fnic/fnic_trace.c > >> +++ b/drivers/scsi/fnic/fnic_trace.c > >> @@ -468,14 +468,14 @@ int fnic_trace_buf_init(void) > >> fnic_max_trace_entries = (trace_max_pages * PAGE_SIZE)/ > >> FNIC_ENTRY_SIZE_BYTES; > >> > >> - fnic_trace_buf_p = (unsigned long)vmalloc((trace_max_pages * > >> PAGE_SIZE)); > >> + fnic_trace_buf_p = (unsigned long)vzalloc((trace_max_pages * > >> + PAGE_SIZE)); > > > > If you remove the extra brackets in vzalloc() argument then you may not > > spill onto the next line. > > And remove the unnecessary cast. vzalloc() (just like vmalloc()) returns > a void*, so no reason to cast it. > > -- > Johannes Thumshirn SUSE Labs > jthumshirn@xxxxxxx +49 911 74053 689 > SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg > GF: Felix Imendörffer, Jane Smithard, Graham Norton > HRB 21284 (AG Nürnberg) > Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850 I will remove it and send v2
