Re: [PATCH 1/1] qla2xxx: Initialize port speed to avoid setting lower speed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2018-11-06 at 00:51 -0800, Himanshu Madhani wrote:
> From: Quinn Tran <quinn.tran@xxxxxxxxxx>
> 
> This patch initializes port speed so that firmware does not
> set lower operating speed. Setting lower speed in firmware
> impacts WRITE perfomance.
> 
> Fixes: 726b85487067 ("qla2xxx: Add framework for async fabric discovery")
> Cc: <stable@xxxxxxxxxxxxxxx>
> Singed-off-by: Quinn Tran <quinn.tran@xxxxxxxxxx>
> Signed-off-by: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>
> Tested-by: Laurence Oberman <loberman@xxxxxxxxxx>
> ---
> Hi Martin, 
> 
> This patch fixes initialization issue for the driver which results into setting lower
> speed for WRITE transfer. In our latest experiments we have seen improvments of 47%
> for WRITE data 
> 
> Please apply this patch to 4.20/scsi-fixes for 4.20-rcX inclusion at your earliest convenience.
> 
> Thanks,
> Himanshu
> ---
>  drivers/scsi/qla2xxx/qla_init.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c
> index 36d67230c3b1..92d2c6866e35 100644
> --- a/drivers/scsi/qla2xxx/qla_init.c
> +++ b/drivers/scsi/qla2xxx/qla_init.c
> @@ -4791,6 +4791,7 @@ qla2x00_alloc_fcport(scsi_qla_host_t *vha, gfp_t flags)
>  	fcport->loop_id = FC_NO_LOOP_ID;
>  	qla2x00_set_fcport_state(fcport, FCS_UNCONFIGURED);
>  	fcport->supported_classes = FC_COS_UNSPECIFIED;
> +	fcport->fp_speed = PORT_SPEED_UNKNOWN;
>  
>  	fcport->ct_desc.ct_sns = dma_alloc_coherent(&vha->hw->pdev->dev,
>  		sizeof(struct ct_sns_pkt), &fcport->ct_desc.ct_sns_dma,

Thanks Laurence for the bisect that found this...

Reviewed-by: Ewan D. Milne <emilne@xxxxxxxxxx>




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux