On 10/30/18 1:45 AM, Christoph Hellwig wrote: > On Mon, Oct 29, 2018 at 02:42:12PM -0600, Jens Axboe wrote: >> LGTM, for both: > > I also have this one on top as requested by Martin. The core block > bidi support is unfortunately also used by bsg-lib, although it is > not anywhere near as invasive. But that is another argument for > looking into moving bsg-lib away from using block queues.. For the block parts, there's really not much there. But it'd be nice to remove that as well, if someone wants to undertake the job of moving bsg-lib away from the request_queue. -- Jens Axboe