On 10/30/18 9:08 AM, Keith Busch wrote: > On Tue, Oct 30, 2018 at 08:53:37AM -0600, Jens Axboe wrote: >> The sum of the set can't exceed the nvecs passed in, the nvecs passed in >> should be the less than or equal to nvecs. Granted this isn't enforced, >> and perhaps that should be the case. > > That should at least initially be true for a proper functioning > driver. It's not enforced as you mentioned, but that's only related to > the issue I'm referring to. > > The problem is pci_alloc_irq_vectors_affinity() takes a range, min_vecs > and max_vecs, but a range of allowable vector allocations doesn't make > sense when using sets. I feel like we're going in circles here, not sure what you feel the issue is now? The range is fine, whoever uses sets will need to adjust their sets based on what pci_alloc_irq_vectors_affinity() returns, if it didn't return the passed in desired max. -- Jens Axboe
