Re: [PATCH 3/7] qla2xxx: Declare local functions 'static'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> On Oct 18, 2018, at 3:45 PM, Bart Van Assche <bvanassche@xxxxxxx> wrote:
> 
> External Email
> 
> This patch avoids that the compiler complains about missing declarations
> when building with W=1.
> 
> Cc: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>
> Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx>
> ---
> drivers/scsi/qla2xxx/qla_init.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c
> index 2ccf9f190c68..6fe20c27acc1 100644
> --- a/drivers/scsi/qla2xxx/qla_init.c
> +++ b/drivers/scsi/qla2xxx/qla_init.c
> @@ -425,7 +425,7 @@ void qla24xx_handle_adisc_event(scsi_qla_host_t *vha, struct event_arg *ea)
>        __qla24xx_handle_gpdb_event(vha, ea);
> }
> 
> -int qla_post_els_plogi_work(struct scsi_qla_host *vha, fc_port_t *fcport)
> +static int qla_post_els_plogi_work(struct scsi_qla_host *vha, fc_port_t *fcport)
> {
>        struct qla_work_evt *e;
> 
> @@ -1551,7 +1551,8 @@ void qla24xx_handle_relogin_event(scsi_qla_host_t *vha,
> }
> 
> 
> -void qla_handle_els_plogi_done(scsi_qla_host_t *vha, struct event_arg *ea)
> +static void qla_handle_els_plogi_done(scsi_qla_host_t *vha,
> +                                     struct event_arg *ea)
> {
>        ql_dbg(ql_dbg_disc, vha, 0x2118,
>            "%s %d %8phC post PRLI\n",
> --
> 2.19.1.568.g152ad8e336-goog
> 

Looks good. 

Acked-by: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx> 

Thanks,
- Himanshu





[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux