> On Oct 18, 2018, at 3:45 PM, Bart Van Assche <bvanassche@xxxxxxx> wrote:
>
> External Email
>
> This patch avoids that the compiler complains about missing fall-through
> annotations when building with W=1.
>
> Cc: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>
> Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx>
> ---
> drivers/scsi/qla2xxx/qla_init.c | 2 +-
> drivers/scsi/qla2xxx/qla_target.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c
> index c72d8012fe2a..2ccf9f190c68 100644
> --- a/drivers/scsi/qla2xxx/qla_init.c
> +++ b/drivers/scsi/qla2xxx/qla_init.c
> @@ -680,7 +680,7 @@ static void qla24xx_handle_gnl_done_event(scsi_qla_host_t *vha,
> fcport);
> break;
> }
> - /* drop through */
> + /* fall through */
> default:
> if (fcport_is_smaller(fcport)) {
> /* local adapter is bigger */
> diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
> index 3015f1bbcf1a..902f9c25da2e 100644
> --- a/drivers/scsi/qla2xxx/qla_target.c
> +++ b/drivers/scsi/qla2xxx/qla_target.c
> @@ -4540,7 +4540,7 @@ static int qlt_issue_task_mgmt(struct fc_port *sess, u64 lun,
> case QLA_TGT_CLEAR_TS:
> case QLA_TGT_ABORT_TS:
> abort_cmds_for_lun(vha, lun, a->u.isp24.fcp_hdr.s_id);
> - /* drop through */
> + /* fall through */
> case QLA_TGT_CLEAR_ACA:
> h = qlt_find_qphint(vha, mcmd->unpacked_lun);
> mcmd->qpair = h->qpair;
> --
> 2.19.1.568.g152ad8e336-goog
>
Looks good.
Acked-by: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>
Thanks,
- Himanshu
