Re: [PATCH 08/28] scsi: kill off the legacy IO path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/25/18 3:36 PM, Bart Van Assche wrote:
> On Thu, 2018-10-25 at 15:10 -0600, Jens Axboe wrote:
>> @@ -3265,25 +3261,17 @@ qla2x00_probe_one(struct pci_dev *pdev, const struct pci_device_id *id)
>>  	    base_vha->mgmt_svr_loop_id, host->sg_tablesize);
>>  
>>  	if (ha->mqenable) {
>> -		bool mq = false;
>>  		bool startit = false;
>>  
>> -		if (QLA_TGT_MODE_ENABLED()) {
>> -			mq = true;
>> +		if (QLA_TGT_MODE_ENABLED())
>>  			startit = false;
>> -		}
>>  
>> -		if ((ql2x_ini_mode == QLA2XXX_INI_MODE_ENABLED) &&
>> -		    shost_use_blk_mq(host)) {
>> -			mq = true;
>> +		if (ql2x_ini_mode == QLA2XXX_INI_MODE_ENABLED)
>>  			startit = true;
>> -		}
>>  
>> -		if (mq) {
>> -			/* Create start of day qpairs for Block MQ */
>> -			for (i = 0; i < ha->max_qpairs; i++)
>> -				qla2xxx_create_qpair(base_vha, 5, 0, startit);
>> -		}
>> +		/* Create start of day qpairs for Block MQ */
>> +		for (i = 0; i < ha->max_qpairs; i++)
>> +			qla2xxx_create_qpair(base_vha, 5, 0, startit);
>>  	}
>>  
>>  	if (ha->flags.running_gold_fw)
> 
> (+Himanshu)
> 
> Since I'm not sure that "mq" in the above code refers to "scsi-mq" nor that it
> refers to "blk-mq", I'm not sure the above changes should be included in this
> patch. Himanshu, can you have a look?

There's literally a comment there that says "for Block MQ" :-)

>> +static ssize_t
>> +show_use_blk_mq(struct device *dev, struct device_attribute *attr, char *buf)
>> +{
>> +	return snprintf(buf, 20, "1\n");
>> +}
>> +static DEVICE_ATTR(use_blk_mq, S_IRUGO, show_use_blk_mq, NULL);
> 
> The pattern "snprintf(buf, 20, ...)" looks like cargo-cult programming to me.
> Please consider changing "snprintf(buf, 20, " into "sprintf(buf, ".

Good point, I'll do that.

-- 
Jens Axboe




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux