Hello Doug, > Examples please, preferably from the SCSI subsystem. If not, I'll do what > most other drivers do, drop all debug statements. $ git grep trace drivers/scsi/scsi* and $ less include/trace/events/scsi.h We currently only have trace points for command dispatch, completion, and a few error scenarios. As of yet there is no explicit tracing in the ULDs. Mostly because so far it hasn't been needed since the ML tracing will parse CDBs and dump most useful fields. And the ULDs generally have no state of their own above what's in the scsi_cmnd. But if you have a specific set of things that would be useful to inspect in the sg state, by all means introduce trace points for them. -- Martin K. Petersen Oracle Linux Engineering
