Jens, On 2018/10/23 16:59, Jens Axboe wrote: > On 10/12/18 4:08 AM, Damien Le Moal wrote: >> This series improves zoned block device support (reduce overhead) and >> introduces many simplifications to the code (overall, there are more deletions >> than insertions). >> >> In more details: >> * Patches 1 to 3 are SCSI side (sd driver) cleanups and improvements reducing >> the overhead of report zones command execution during disk scan and >> revalidation. >> * Patches 4 to 9 improve the useability and user API of zoned block devices. >> * Patch 10 is the main part of this series. This patch replaces the >> REQ_OP_ZONE_REPORT BIO/request operation for executing report zones commands >> with a block device file operation, removing the need for the command reply >> payload in-place rewriting in the BIO buffer. This leads to major >> simplification of the code in many places. >> * Patch 11 further simplifies the code of low level drivers by providing a >> generic implementation of zoned block device reuest queue zone bitmaps >> initialization and revalidation. > > I've applied this, but I have two complaints: > > 1) Two had to be hand applied, it wasn't against the block tree. My apologies for that. I had to rebase against the latest RC because of a conflict with late fixes in DM. I should have checked more carefully against the block tree after that. Sorry about this, I will be more careful going forward. > 2) The ordering of the signed-off-by. Someone told me that this is > patchwork, but I absolutely hate it. SOB should go last, not before > the reviewed-by. I fixed that up too. Thank you. I think this was me rather than patchwork when I a manually added the reviewed-by tags with new versions of the series. I will remember this and tag in you preferred order. Thank you. Best regards. -- Damien Le Moal Western Digital Research