On Tue, Oct 23, 2018 at 7:47 PM, Martin K. Petersen <martin.petersen@xxxxxxxxxx> wrote: > > John, > > Thanks for tweaking this. > >> Not sure if this is the preferred way of scoping the quirk to >> the controller or not. Feedback would be greatly appreciated! > > I think my preference would be to add: > > UFS_FIX(UFS_VENDOR_SKHYNIX, "hB8aL1", > UFS_DEVICE_QUIRK_HOST_VS_DEBUG), > > to ufs_fixups[] and then key off of that in the driver. That's how we do > it in SCSI but the UFS folks may have a different opinion. Ok. Yea, I saw something similar in the qcom code, but I wasn't sure if folks would want host specific quirks isolated to host code. I appreciate the clarification, I'll rework and respin it here shortly. Thanks again! -john