Re: [PATCH 5/8] sg: add free list, rework locking

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi linux-scsi-owner,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on mkp-scsi/for-next]
[also build test ERROR on v4.19-rc8 next-20181019]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/linux-scsi-owner-vger-kernel-org/sg-major-cleanup-remove-max_queue-limit/20181019-183809
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
config: i386-randconfig-i1-201841 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   drivers/scsi/sg.o: In function `sg_rq_end_io_usercontext':
>> drivers/scsi/sg.c:1494: undefined reference to `sg_rq_state_str'
>> drivers/scsi/sg.c:1494: undefined reference to `sg_rq_state_str'

vim +1494 drivers/scsi/sg.c

  1470	
  1471	/*
  1472	 * This user context function is needed to clean up a request that has been
  1473	 * interrupted (e.g. by control-C at keyboard). That leads to a request
  1474	 * being an 'orphan' and will be cleared here unless the 'keep_orphan' flag
  1475	 * has been set on the owning file descriptor. In that case the user is
  1476	 * expected to call read() or ioctl(SG_IORECEIVE) to receive the response
  1477	 * and free resources held by the interrupted request.
  1478	 */
  1479	static void
  1480	sg_rq_end_io_usercontext(struct work_struct *work)
  1481	{
  1482		struct sg_request *srp = container_of(work, struct sg_request, ew.work);
  1483		struct sg_fd *sfp;
  1484	
  1485		if (!srp) {
  1486			WARN_ONCE("s: srp unexpectedly NULL\n", __func__);
  1487			return;
  1488		}
  1489		sfp = srp->parentfp;
  1490		if (!sfp) {
  1491			WARN_ONCE(1, "%s: sfp unexpectedly NULL\n", __func__);
  1492			return;
  1493		}
> 1494		SG_LOG(3, sfp->parentdp, "%s: clean srp=0x%p, rq_state: %s\n",
  1495		       __func__, srp, sg_rq_state_str(srp->rq_state, true));
  1496		sg_finish_scsi_blk_rq(srp);
  1497		sg_remove_request(sfp, srp);
  1498		kref_put(&sfp->f_ref, sg_remove_sfp);
  1499	}
  1500	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux