Re: [PATCH 5/8] sg: add free list, rework locking

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi linux-scsi-owner,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on mkp-scsi/for-next]
[also build test WARNING on v4.19-rc8 next-20181019]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/linux-scsi-owner-vger-kernel-org/sg-major-cleanup-remove-max_queue-limit/20181019-183809
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
config: i386-randconfig-x078-201841 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

>> drivers//scsi/sg.c:240:20: warning: 'sg_rq_state_str' used but never defined
    static const char *sg_rq_state_str(u8 rq_state, bool long_str);
                       ^~~~~~~~~~~~~~~
   drivers//scsi/sg.c:933:1: warning: 'sg_fill_request_table' defined but not used [-Wunused-function]
    sg_fill_request_table(struct sg_fd *sfp, struct sg_req_info *rinfo,
    ^~~~~~~~~~~~~~~~~~~~~
   drivers//scsi/sg.c:19:12: warning: 'sg_version_num' defined but not used [-Wunused-variable]
    static int sg_version_num = 30901; /* 2 digits for each component */
               ^~~~~~~~~~~~~~

vim +/sg_rq_state_str +240 drivers//scsi/sg.c

   212	
   213	/* tasklet or soft irq callback */
   214	static void sg_rq_end_io(struct request *rq, blk_status_t status);
   215	static int sg_start_req(struct sg_request *srp, u8 *cmd);
   216	static void sg_finish_scsi_blk_rq(struct sg_request *srp);
   217	static int sg_mk_sgat_dlen(struct sg_request *srp, struct sg_fd *sfp,
   218				   int dlen);
   219	static ssize_t sg_new_read(struct sg_fd *sfp, char __user *buf, size_t count,
   220				   struct sg_request *srp);
   221	static ssize_t sg_v3_write(struct sg_fd *sfp, struct file *file,
   222				   const char __user *buf, size_t count,
   223				   bool read_only, bool sync,
   224				   struct sg_request **o_srp);
   225	static struct sg_request *sg_common_write(struct sg_fd *sfp,
   226						  const struct sg_io_hdr *hp,
   227						  struct sg_io_v4 *h4p, u8 *cmnd,
   228						  bool sync, int timeout);
   229	static int sg_read_oxfer(struct sg_request *srp, char __user *outp,
   230				 int num_xfer);
   231	static void sg_remove_sgat(struct sg_request *srp);
   232	static struct sg_fd *sg_add_sfp(struct sg_device *sdp);
   233	static void sg_remove_sfp(struct kref *);
   234	static struct sg_request *sg_get_rq_pack_id(struct sg_fd *sfp, int pack_id);
   235	static struct sg_request *sg_add_request(struct sg_fd *sfp, int dxfr_len,
   236						 bool sync);
   237	static void sg_remove_request(struct sg_fd *sfp, struct sg_request *srp);
   238	static struct sg_device *sg_get_dev(int min_dev);
   239	static void sg_device_destroy(struct kref *kref);
 > 240	static const char *sg_rq_state_str(u8 rq_state, bool long_str);
   241	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux