On Thursday 18 October 2018 15:01:14 Christoph Hellwig wrote: > Hi Ondrej, > > can you look over this series, which cleans up a few dma-related > bits in the wd719x driver? > Looks nice but does not work. The first patch works, but the 2nd one causes hang on modprobe: [ 408.350359] wd719x 0000:00:0c.0: RISC initialized with firmware version 03.10 [ 408.949225] wd719x 0000:00:0c.0: WD7193 at I/O 0xe800, IRQ 5, SCSI ID 7 [ 408.954450] scsi host2: Western Digital 719x [ 409.263961] wd719x 0000:00:0c.0: invalid SCSI phase [ 409.297203] wd719x 0000:00:0c.0: invalid SCSI phase [ 409.325714] scsi 2:0:1:0: Direct-Access QUANTUM LP240S GM240S01X 4.6 PQ: 0 ANSI: 2 CCS [ 409.346106] wd719x 0000:00:0c.0: invalid SCSI phase [ 409.380731] wd719x 0000:00:0c.0: invalid SCSI phase [ 410.748579] sd 2:0:1:0: Attached scsi generic sg1 type 0 -- Ondrej Zary