On 10/17/18 12:08 PM, Douglas Gilbert wrote: > On 2018-10-17 11:55 a.m., Benjamin Block wrote: >> On Tue, Oct 16, 2018 at 08:43:01AM -0600, Jens Axboe wrote: >>> Requires a few changes to the FC transport class as well. >>> >>> Cc: Johannes Thumshirn <jthumshirn@xxxxxxx> >>> Cc: Benjamin Block <bblock@xxxxxxxxxxxxxxxxxx> >>> Cc: linux-scsi@xxxxxxxxxxxxxxx >>> Signed-off-by: Jens Axboe <axboe@xxxxxxxxx> >>> --- >>> block/bsg-lib.c | 102 +++++++++++++++++-------------- >>> drivers/scsi/scsi_transport_fc.c | 61 ++++++++++-------- >>> 2 files changed, 91 insertions(+), 72 deletions(-) >>> >> >> Hey Jens, >> >> I haven't had time to look into this in any deep way - but I did plan to >> -, but just to see whether it starts and runs some I/O I tried giving it >> a spin and came up with nothing (see line 3 and 5): >> >> [ 14.082079] scsi host0: scsi_eh_0: sleeping >> [ 14.082288] scsi host0: zfcp >> [ 14.086823] scsi host0: fc_host0: bsg interface failed to initialize - setup queue >> [ 14.089198] qdio: 0.0.1900 ZFCP on SC 107 using AI:1 QEBSM:0 PRI:1 TDD:1 SIGA: W AP >> [ 15.228583] rport-0:0-0: failed to setup bsg queue >> [ 15.229886] scsi 0:0:0:0: scsi scan: INQUIRY pass 1 length 36 >> [ 15.230801] scsi 0:0:0:0: scsi scan: INQUIRY successful with code 0x0 >> [ 15.230860] scsi 0:0:0:0: scsi scan: INQUIRY pass 2 length 164 >> [ 15.231171] scsi 0:0:0:0: scsi scan: INQUIRY successful with code 0x0 >> [ 15.231190] scsi 0:0:0:0: scsi scan: peripheral device type of 31, no device added >> [ 15.233171] scsi 0:0:0:0: scsi scan: Sending REPORT LUNS to (try 0) >> [ 15.234144] scsi 0:0:0:0: scsi scan: REPORT LUNS successful (try 0) result 0x0 >> [ 15.234156] scsi 0:0:0:0: scsi scan: REPORT LUN scan >> [ 15.235040] scsi 0:0:0:1082671104: scsi scan: INQUIRY pass 1 length 36 >> [ 15.235220] scsi host1: scsi_eh_1: sleeping >> [ 15.235336] scsi 0:0:0:1082671104: scsi scan: INQUIRY successful with code 0x0 >> [ 15.235355] scsi 0:0:0:1082671104: scsi scan: INQUIRY pass 2 length 164 >> [ 15.235434] scsi host1: zfcp >> [ 15.235667] scsi 0:0:0:1082671104: scsi scan: INQUIRY successful with code 0x0 >> [ 15.235709] scsi 0:0:0:1082671104: Direct-Access IBM 2107900 3230 PQ: 0 ANSI: 5 >> [ 15.238468] scsi host1: fc_host1: bsg interface failed to initialize - setup queue >> .... >> >> Seems to already fail at setting up the bsg interfaces for zFCP - at >> loading time of the module. This is just your patch on top of >> 4.19.0-rc8. > > Hi, > Almost all of the utilities in the sg3_utils package (a few exceptions: > sg_reset, sgm_dd, sgp_dd), when given a bsg file node (e.g. > 'sg_inq /dev/bsg/0:0:0:1'), will use the bsg sg_v4 interface (i.e. as > defined in <uapi/linux/bsg.h>). Dito with the sdparm and ddpt packages. > So there is a lot of test code for any changes to the bsg driver. That's good info, I did in fact run test tools on the bsg nodes and verified that it worked fine. But I could not test the embedded queues like Benjamin is doing above - and those were broken due to a silly wrong pointer check. So hopefully with that fixed, it'll work just fine. -- Jens Axboe
