On Tue, 16 Oct 2018, 4:39pm, Laurence Oberman wrote: > External Email > > This message floods the log when enabling mask 0x7 for > /proc/sys/dev/scsi/logging_level > xxxxxxxx kernel: scsi_block_when_processing_errors: rtn: 1 > Its not needed and makes tracing just scsi_eh* messages way too verbose > so get rid of it > > Signed-off-by: Laurence Oberman <loberman@xxxxxxxxxx> > > --- > drivers/scsi/scsi_error.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c > index b7a8fdf..c736d61 100644 > --- a/drivers/scsi/scsi_error.c > +++ b/drivers/scsi/scsi_error.c > @@ -338,9 +338,6 @@ int scsi_block_when_processing_errors(struct > scsi_device *sdev) > > online = scsi_device_online(sdev); > > - SCSI_LOG_ERROR_RECOVERY(5, sdev_printk(KERN_INFO, sdev, > - "%s: rtn: %d\n", __func__, online)); > - > return online; > } > EXPORT_SYMBOL(scsi_block_when_processing_errors); > -- > 1.8.3.1 > Hit this a few times myself. Thanks for taking it out. Reviewed-by: Chad Dupuis <chad.dupuis@xxxxxxxxxx>
