Re: [PATCH v4 00/11] Zoned block device support improvements

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Martin, Mike,

On 2018/10/16 11:34, Jens Axboe wrote:
> On 10/14/18 6:45 PM, Damien Le Moal wrote:
>> Jens,
>>
>> On 2018/10/14 7:43, Jens Axboe wrote:
>>> On 10/12/18 4:08 AM, Damien Le Moal wrote:
>>>> This series improves zoned block device support (reduce overhead) and
>>>> introduces many simplifications to the code (overall, there are more deletions
>>>> than insertions).
>>>>
>>>> In more details:
>>>> * Patches 1 to 3 are SCSI side (sd driver) cleanups and improvements reducing
>>>>   the overhead of report zones command execution during disk scan and
>>>>   revalidation.
>>>> * Patches 4 to 9 improve the useability and user API of zoned block devices.
>>>> * Patch 10 is the main part of this series. This patch replaces the
>>>>   REQ_OP_ZONE_REPORT BIO/request operation for executing report zones commands
>>>>   with a block device file operation, removing the need for the command reply
>>>>   payload in-place rewriting in the BIO buffer. This leads to major
>>>>   simplification of the code in many places.
>>>> * Patch 11 further simplifies the code of low level drivers by providing a
>>>>   generic implementation of zoned block device request queue zone bitmaps
>>>>   initialization and revalidation.
>>>>
>>>> Please consider the addition of these patches in 4.20.
>>>> Comments are as always welcome.
>>>
>>> How do we want to funnel this series? 1-3 look separate, so perhaps
>>> they should go through the scsi tree. Then I can take the rest. Or do
>>> some of the later ones depend on 1-3 being in, in terms of applying
>>> cleanly?  I can also take all of them, looks like only #3 needs a
>>> SCSI ack.
>>
>> Patch 10 and 11 will not apply cleanly for the scsi part without 1-3
>> in first.  1-3, 10 and 11 would need an ack/review from Martin (SCSI).
>> And 10-11 also probably need an ack/review from Mike for the DM
>> changes.
> 
> Probably want to start pinging people, if you're targeting 4.20 with
> this...

Could you please review or ack the parts relevant to SCSI and DM of this
series ?

For DM, changes are in patches 10 and 11
For SCSI, patches 1-3, 10 and 11 introduce changes.

Thank you.

Best regards.

-- 
Damien Le Moal
Western Digital Research




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux