Re: [PATCH v3] target: split out helper for cxn timeout error stashing

[kbuild test robot <lkp@xxxxxxxxx>]

Hi David,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on target/master]
[also build test ERROR on v4.19-rc7 next-20181012]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/David-Disseldorp/target-split-out-helper-for-cxn-timeout-error-stashing/20181014-111810
base:   https://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git master
config: i386-randconfig-s1-201841 (attached as .config)
compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   drivers/target/iscsi/iscsi_target_util.c: In function 'iscsit_handle_nopin_response_timeout':
>> drivers/target/iscsi/iscsi_target_util.c:902:36: error: 'sess' undeclared (first use in this function)
     iscsit_fill_cxn_timeout_err_stats(sess);
                                       ^~~~
   drivers/target/iscsi/iscsi_target_util.c:902:36: note: each undeclared identifier is reported only once for each function it appears in

vim +/sess +902 drivers/target/iscsi/iscsi_target_util.c

   882	
   883	static void iscsit_handle_nopin_response_timeout(unsigned long data)
   884	{
   885		struct iscsi_conn *conn = (struct iscsi_conn *) data;
   886	
   887		iscsit_inc_conn_usage_count(conn);
   888	
   889		spin_lock_bh(&conn->nopin_timer_lock);
   890		if (conn->nopin_response_timer_flags & ISCSI_TF_STOP) {
   891			spin_unlock_bh(&conn->nopin_timer_lock);
   892			iscsit_dec_conn_usage_count(conn);
   893			return;
   894		}
   895	
   896		pr_debug("Did not receive response to NOPIN on CID: %hu on"
   897			" SID: %u, failing connection.\n", conn->cid,
   898				conn->sess->sid);
   899		conn->nopin_response_timer_flags &= ~ISCSI_TF_RUNNING;
   900		spin_unlock_bh(&conn->nopin_timer_lock);
   901	
 > 902		iscsit_fill_cxn_timeout_err_stats(sess);
   903		iscsit_cause_connection_reinstatement(conn, 0);
   904		iscsit_dec_conn_usage_count(conn);
   905	}
   906	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip