On Thu, Oct 11, 2018 at 08:49:58PM +0200, Christoph Hellwig wrote:
> @@ -9026,19 +9026,13 @@ static void qla4xxx_remove_adapter(struct pci_dev *pdev)
> */
> static void qla4xxx_config_dma_addressing(struct scsi_qla_host *ha)
> {
> - int retval;
> -
Can you zap that:
At exit, the @ha's flags.enable_64bit_addressing set to indicated
supported addressing method.
Comment in the function description as well? It wasn't even correct
with the initial submission of qla4xxx (according to git blame.
Otherwise,
Reviewed-by: Johannes Thumshirn <jthumshirn@xxxxxxx>
--
Johannes Thumshirn SUSE Labs
jthumshirn@xxxxxxx +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
