On Thu, Oct 11, 2018 at 08:49:41PM +0200, Christoph Hellwig wrote:
> @@ -1124,7 +1124,8 @@ static int inia100_probe_one(struct pci_dev *pdev,
>
> /* Get total memory needed for SCB */
> sz = ORC_MAXQUEUE * sizeof(struct orc_scb);
> - host->scb_virt = pci_zalloc_consistent(pdev, sz, &host->scb_phys);
> + host->scb_virt = dma_zalloc_coherent(&pdev->dev, sz, &host->scb_phys,
> + GFP_KERNEL);
Nit: Indentation looks a bit odd here.
> if (!host->scb_virt) {
> printk("inia100: SCB memory allocation error\n");
> goto out_host_put;
> @@ -1132,7 +1133,8 @@ static int inia100_probe_one(struct pci_dev *pdev,
>
> /* Get total memory needed for ESCB */
> sz = ORC_MAXQUEUE * sizeof(struct orc_extended_scb);
> - host->escb_virt = pci_zalloc_consistent(pdev, sz, &host->escb_phys);
> + host->escb_virt = dma_zalloc_coherent(&pdev->dev, sz, &host->escb_phys,
> + GFP_KERNEL);
and here.
Otherwise,
Reviewed-by: Johannes Thumshirn <jthumshirn@xxxxxxx>
--
Johannes Thumshirn SUSE Labs
jthumshirn@xxxxxxx +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
