On Thu, Oct 11, 2018 at 11:10:36AM +1100, Finn Thain wrote: > If you do so, can you also eliminate the dev argument to > scsi_esp_register()? Sure. > > - struct platform_device *op = esp->dev; > > + struct platform_device *op = to_platform_device(esp->dev); > > > > - esp->command_block = dma_alloc_coherent(&op->dev, 16, > > + esp->command_block = dma_alloc_coherent(dev, 16, > > Shouldn't that be esp->dev? Yes. This slipped through because this function gets removed in the next patch..