Re: [PATCH 3/4] esp_scsi: use strong typing for the dev field

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 11, 2018 at 11:10:36AM +1100, Finn Thain wrote:
> If you do so, can you also eliminate the dev argument to 
> scsi_esp_register()?

Sure.

> > -	struct platform_device *op = esp->dev;
> > +	struct platform_device *op = to_platform_device(esp->dev);
> >  
> > -	esp->command_block = dma_alloc_coherent(&op->dev, 16,
> > +	esp->command_block = dma_alloc_coherent(dev, 16,
> 
> Shouldn't that be esp->dev?

Yes.  This slipped through because this function gets removed in the
next patch..



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux