Hi Gustavo, > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. I'm not entirely convinced that all these identified fall through cases are intentional. From a quick glance, some of them look like bugs... > diff --git a/drivers/scsi/ips.c b/drivers/scsi/ips.c > index bd6ac6b..8e1c45d 100644 > --- a/drivers/scsi/ips.c > +++ b/drivers/scsi/ips.c > @@ -3485,6 +3485,7 @@ ips_send_cmd(ips_ha_t * ha, ips_scb_t * scb) > > case START_STOP: > scb->scsi_cmd->result = DID_OK << 16; > + /* fall through */ > > case TEST_UNIT_READY: > case INQUIRY: -- Martin K. Petersen Oracle Linux Engineering
