On 10/8/18 10:22 PM, Ewan D. Milne wrote:
This change would permit a device that was OFFLINE (for any reason)
to go back to RUNNING via: OFFLINE -> BLOCKED -> RUNNING
Correct.
Obviously that was your intention, but e.g. if a device was put
OFFLINE due to exceeding max_medium_access_timeouts a fabric
event and recovery would put it back online.
Same would be true if someone had put the device offline via sysfs.
If an rport goes away due to devloss, and comes back, then we rescan
so this doesn't matter because we recreate the sdev anyway, right?
Exactly. Once devloss_tmo triggers the sdev will be recreated and we
lose all settings we might have done.
And experience shows that about 95% of all SCSI EH invocations on FC are
due to a SAN configuration problems; I think I've seen a 'real' SCSI
error only 3 times, and only one of them registered as a medium error.
So rechecking the device after RSCN is a sensible choice.
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@xxxxxxx +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
