On Sun, 2018-09-30 at 08:45 +-0300, Avri Altman wrote: +AD4 +-+-+- b/include/uapi/scsi/scsi+AF8-bsg+AF8-ufs.h +AD4 +AEAAQA -0,0 +-1,74 +AEAAQA +AD4 +-/+ACo SPDX-License-Identifier: GPL-2.0 +ACo-/ +AD4 +-/+ACo +AD4 +- +ACo TBD - UFS Transport SGIO v4 BSG Message Support +AD4 +- +ACo +AD4 +- +ACo Copyright (C) 2011-2013 Samsung India Software Operations +AD4 +- +ACo-/ +AD4 +-+ACM-ifndef SCSI+AF8-BSG+AF8-UFS+AF8-H +AD4 +-+ACM-define SCSI+AF8-BSG+AF8-UFS+AF8-H +AD4 +- +AD4 +-/+ACo +AD4 +- +ACo This file intended to be included by both kernel and user space +AD4 +- +ACo-/ +AD4 +- +AD4 +-+ACM-define MAX+AF8-CDB+AF8-SIZE 16 Please rename this constant such that it has either +ACI-UFS+ACI or +ACI-UTP+ACI in its name. This name is too generic for a protocol-specific header file. Thanks, Bart.