On Fri, Sep 29, 2006 at 06:15:42PM +0100, Alan Cox wrote: > Ar Gwe, 2006-09-29 am 08:39 -0600, ysgrifennodd Matthew Wilcox: > > On Fri, Sep 29, 2006 at 03:57:38PM +0200, J.A. Magall??n wrote: > > > aic7xxx oopses on boot: > > > > > > PCI: Setting latency timer of device 0000:00:0e.0 to 64 > > > IRQ handler type mismatch for IRQ 0 > > > > Of course, this isn't a scsi problem, it's a peecee hardware problem. > > Or maybe a PCI subsystem problem. But it's clearly not aic7xxx's fault. > > AIC7xxx finding it has no IRQ configured is valid (annoying, stupid and > valid) so the driver should check before requesting "no IRQ" > Alan, Does this patch makes sense in that case? If yes, I'll put up a patch for the remaining cases in the drivers/scsi/aic7xxx/ directory. Also, aic7xxx's coding style would put parenthesis around the returned value, should I follow it? Regards, Frederik diff --git a/drivers/scsi/aic7xxx/aic7xxx_osm_pci.c b/drivers/scsi/aic7xxx/aic7xxx_osm_pci.c index ea5687d..38f5ca7 100644 --- a/drivers/scsi/aic7xxx/aic7xxx_osm_pci.c +++ b/drivers/scsi/aic7xxx/aic7xxx_osm_pci.c @@ -185,6 +185,9 @@ ahc_linux_pci_dev_probe(struct pci_dev * int error; struct device *dev = &pdev->dev; + if (!pdev->irq) + return -ENODEV; + pci = pdev; entry = ahc_find_pci_device(pci); if (entry == NULL) - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
