Avri, > this looks generally good to me, but I'd suggest two small tweaks: > > - please split out a new prep patch that creates > include/uapi/scsi/scsi_bsg_ufs.h with the structures move there > - pleae keep the copyrights from drivers/scsi/ufs/ufs.h in this > new file Also, when you repost, please make sure to carry over Reviewed-by: tags received for patches you haven't (substantially) changed. Looking over these yesterday, I noticed they were a blank slate in the tags department and that's very unusual for a 6th iteration of a patch set. -- Martin K. Petersen Oracle Linux Engineering