On Tue, Sep 25, 2018 at 1:29 PM Suganath Prabu Subramani <suganath-prabu.subramani@xxxxxxxxxxxx> wrote: > > On Tue, Sep 25, 2018 at 3:22 PM Andy Shevchenko > <andy.shevchenko@xxxxxxxxx> wrote: > > > > On Tue, Sep 25, 2018 at 12:46 PM Suganath Prabu Subramani > > <suganath-prabu.subramani@xxxxxxxxxxxx> wrote: > > > > > > > + pr_err(MPT3SAS_FMT > > > > > + "%s: pci error recovery reset or" > > > > > + " pci device unplug occurred\n", > > > > > > > > This should be just one line. > > > Above line crosses over 80 characters, so it is in two lines. > > > > For years there is no such requirement for string literals. > Below is the one i was mentioning, > WARNING: line over 80 characters > #30: FILE: drivers/scsi/mpt3sas/mpt3sas_base.c:6861: > + pr_err(MPT3SAS_FMT "%s: pci error recovery reset or pci device > unplug occurred\n", ioc->name, __func__); > > Warning comes for both characters over 80 chars and string split. > Do you want us to ignore warning and repost like above in single line ? > > Please, don't split string literals in ugly way like this. I didn't tell anything about other parameters to be on the same line. So, please, try again. -- With Best Regards, Andy Shevchenko
