On 09/20/2018 07:32 PM, wenxiong@xxxxxxxxxxxxxxxxxx wrote: > + > + list_for_each_entry(res, &ioa_cfg->used_res_q, queue) { > + if (res->add_to_ml) { > + bus = res->bus; > + target = res->target; > + lun = res->lun; > + res->add_to_ml = 0; > + spin_unlock_irqrestore(ioa_cfg->host->host_lock, lock_flags); > + scsi_add_device(ioa_cfg->host, bus, target, lun); > + spin_lock_irqsave(ioa_cfg->host->host_lock, lock_flags); > + goto restart; > + } > + } ^^^ You have some trailing whitespace here. Otherwise, looks good. Thanks! Acked-by: Brian King <brking@xxxxxxxxxxxxxxxxxx> -- Brian King Power Linux I/O IBM Linux Technology Center