Re: [PATCH v2 1/6] mpt3sas: Introduce mpt3sas_base_pci_device_is_available

[Sreekanth Reddy <sreekanth.reddy@xxxxxxxxxxxx>]

On Thu, Sep 20, 2018 at 4:37 PM Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
>
> > +u8
> > +mpt3sas_base_pci_device_is_available(struct MPT3SAS_ADAPTER *ioc)
> > +{
> > +     if (ioc->pci_error_recovery ||
> > +              (!pci_device_is_present(ioc->pdev)))
> > +             return 0;
> > +
> > +     return 1;
> > +}
>
> This should simplify be:
>
> bool mpt3sas_base_pci_device_is_available(struct MPT3SAS_ADAPTER *ioc)
> {
>         return !ioc->pci_error_recovery && pci_device_is_present(ioc->pdev);
> }
>
> probably even as an inline..

Thank you. we will make this change and also declare this function as inline.

Thanks,
Sreekanth