On Wed, Sep 19, 2018 at 11:32:01AM +0800, Jason Yan wrote: > We are using lldd_port_deformed so we'd better check if lldd_port_deformed > is NULL. > > After this, we can remove hisi_sas_port_deformed() because it is just a > stub to avoid a NULL dereference caused by the wrong check. > The wording seems a bit odd. I'd do something like: libsas: make the lldd_port_deformed method optional ... and remove the dummy implementation in hisi_sas. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>
