On 9/17/18 8:11 AM, Mike Snitzer wrote:
Moving kfree() into setup_scsi_dh() would require use of a common goto for cleanup (something parse_path() already has with 'goto bad;'). But having kfree() in parse_path() is cleaner/symmetric since call to scsi_dh_attached_handler_name() -- and associated memory allocation -- occurs in parse_path(). If you're OK with this, I'll get a proper patch staged based on your header and obviously add a Reported-by attributed to you.
That sounds fine to me. Thanks! Bart.