Re: [PATCH 1/6] qla2xxx_nvmet: Add files for FC-NVMe Target support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>, James.Bottomley@xxxxxxxxxxxxxxxxxxxxx, martin.petersen@xxxxxxxxxx
Subject: Re: [PATCH 1/6] qla2xxx_nvmet: Add files for FC-NVMe Target support
From: Bart Van Assche <bvanassche@xxxxxxx>
Date: Sat, 15 Sep 2018 21:50:18 -0700
Cc: linux-scsi@xxxxxxxxxxxxxxx
In-reply-to: <20180914212811.11463-2-himanshu.madhani@cavium.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1

On 09/14/18 14:28, Himanshu Madhani wrote:

diff --git a/drivers/scsi/qla2xxx/qla_nvmet.c b/drivers/scsi/qla2xxx/qla_nvmet.c
new file mode 100644
[ ... ]
+#if	IS_ENABLED(CONFIG_NVME_TARGET_FC)
[ ... ]
+#endif

This style of using #if / #endif is not acceptable. Instead,drivers/scsi/qla2xxx/Makefile should be modified such that qla_nvmet.cis only built if CONFIG_NVME_TARGET_FC has been set.


Bart.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Follow-Ups:
- Re: [PATCH 1/6] qla2xxx_nvmet: Add files for FC-NVMe Target support
  - From: Madhani, Himanshu

References:
- [PATCH 0/6] qla2xxx: Add FC-NVMe Target support
  - From: Himanshu Madhani
- [PATCH 1/6] qla2xxx_nvmet: Add files for FC-NVMe Target support
  - From: Himanshu Madhani

Prev by Date: Re: [PATCH 4/6] qla2xxx_nvmet: Add FC-NVMe Target handling
Next by Date: Re: [PATCH 2/6] qla2xxx_nvmet: Added Makefile and Kconfig changes
Previous by thread: [PATCH 1/6] qla2xxx_nvmet: Add files for FC-NVMe Target support
Next by thread: Re: [PATCH 1/6] qla2xxx_nvmet: Add files for FC-NVMe Target support
Index(es):
- Date
- Thread

[Index of Archives] [SCSI Target Devel] [Linux SCSI Target Infrastructure] [Kernel Newbies] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Linux IIO] [Samba] [Device Mapper]

Powered by Linux