Re: [PATCH -next] scsi: qla2xxx: Remove set but not used variable 'ptr_dma'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> On Sep 12, 2018, at 7:40 PM, YueHaibing <yuehaibing@xxxxxxxxxx> wrote:
> 
> External Email
> 
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/scsi/qla2xxx/qla_iocb.c: In function 'qla24xx_els_dcmd2_iocb':
> drivers/scsi/qla2xxx/qla_iocb.c:2644:13: warning:
> variable 'ptr_dma' set but not used [-Wunused-but-set-variable]
> 
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
> ---
> drivers/scsi/qla2xxx/qla_iocb.c | 2 --
> 1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_iocb.c b/drivers/scsi/qla2xxx/qla_iocb.c
> index 4de9102..86fb8b2 100644
> --- a/drivers/scsi/qla2xxx/qla_iocb.c
> +++ b/drivers/scsi/qla2xxx/qla_iocb.c
> @@ -2641,7 +2641,6 @@ struct fw_dif_context {
>        struct qla_hw_data *ha = vha->hw;
>        int rval = QLA_SUCCESS;
>        void    *ptr, *resp_ptr;
> -       dma_addr_t ptr_dma;
> 
>        /* Alloc SRB structure */
>        sp = qla2x00_get_sp(vha, fcport, GFP_KERNEL);
> @@ -2673,7 +2672,6 @@ struct fw_dif_context {
>        ptr = elsio->u.els_plogi.els_plogi_pyld =
>            dma_alloc_coherent(&ha->pdev->dev, DMA_POOL_SIZE,
>                &elsio->u.els_plogi.els_plogi_pyld_dma, GFP_KERNEL);
> -       ptr_dma = elsio->u.els_plogi.els_plogi_pyld_dma;
> 
>        if (!elsio->u.els_plogi.els_plogi_pyld) {
>                rval = QLA_FUNCTION_FAILED;
> 

Looks Good. 

Acked-by: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>

Thanks,
- Himanshu





[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux