On Wed, Sep 05, 2018 at 07:30:03AM +0000, Avri Altman wrote: > Looking into the UFSHCI spec (JESD223C March 2016) paragraph 6.2, > It doesn't specify any inner structure of the task management > request or response, just a bunch of 8 DW each. > I guess this is why it is defined as a __le32 array. > > So the host controller is not aware of the inner structure of this > Sequence, and probably shouldn't. Making it aware of that, > e.g. by moving utp_upiu_task_req and utp_upiu_task_rsp > from ufs.h to ufshci.h will break this abstraction. Well, then just kill struct utp_upiu_task_req entirely and use the dwords form the spec.